Fix annoying joqqueue issue where jobs were blocked by unused channel

This commit is contained in:
Jamie Curnow 2024-11-13 08:03:10 +10:00
parent 61c41b8ec3
commit 050c087a51
No known key found for this signature in database
GPG Key ID: FFBB624C43388E9E
2 changed files with 2 additions and 10 deletions

View File

@ -16,7 +16,7 @@ var (
func Start() { func Start() {
ctx, cancel = context.WithCancel(context.Background()) ctx, cancel = context.WithCancel(context.Background())
q := &Queue{ q := &Queue{
jobs: make(chan Job, 10), jobs: make(chan Job, 50),
ctx: ctx, ctx: ctx,
cancel: cancel, cancel: cancel,
} }

View File

@ -17,7 +17,6 @@ type Queue struct {
type Job struct { type Job struct {
Name string Name string
Action func() error // A function that should be executed when the job is running. Action func() error // A function that should be executed when the job is running.
Done chan bool // A channel that should be closed when the job is done.
} }
// AddJobs adds jobs to the queue and cancels channel. // AddJobs adds jobs to the queue and cancels channel.
@ -49,12 +48,5 @@ func (q *Queue) AddJob(job Job) {
// Run performs job execution. // Run performs job execution.
func (j *Job) Run() error { func (j *Job) Run() error {
err := j.Action() return j.Action()
if err != nil {
j.Done <- true
return err
}
j.Done <- true
return nil
} }