ThatGuyJack/nginx-proxy-manager
1
0
Fork 0
mirror of https://github.com/NginxProxyManager/nginx-proxy-manager.git synced 2025-07-19 07:54:34 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix for SSL certificate error #2011

Browse Source 
- Keepalive, User Agent + Accept headers
- Catch added for failed JSON parsing
- More accurate errors displayed to user
This commit is contained in:
S_T_3_V_3
2023-04-23 18:32:34 +10:00
parent 67208e43cc
commit cc5465638e
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
backend/internal/certificate.js
View File

@ -1164,7 +1164,10 @@ const internalCertificate = {
method: 'POST', method: 'POST',
headers: { headers: {
'Content-Type': 'application/x-www-form-urlencoded', 'Content-Type': 'application/x-www-form-urlencoded',
'Content-Length': Buffer.byteLength(formBody) 'Content-Length': Buffer.byteLength(formBody),
'Connection': 'keep-alive',
'User-Agent': 'Nginx Proxy Manager',
'Accept': '*/*'
} }
}; };
@ -1175,12 +1178,16 @@ const internalCertificate = {
res.on('data', (chunk) => responseBody = responseBody + chunk); res.on('data', (chunk) => responseBody = responseBody + chunk);
res.on('end', function () { res.on('end', function () {
const parsedBody = JSON.parse(responseBody + ''); try {
if (res.statusCode !== 200) { const parsedBody = JSON.parse(responseBody + '');
resolve(parsedBody);
}
catch {
logger.warn("Error");
logger.warn(`Status Code: ${res.statusCode}`);
logger.warn(`Failed to test HTTP challenge for domain ${domain}`, res); logger.warn(`Failed to test HTTP challenge for domain ${domain}`, res);
resolve(undefined); resolve(undefined);
} }
resolve(parsedBody);
}); });
}); });