fix: add oidc-config setting via setup.js rather than migrations

backend/migrations/20230226135501_add_oidc_config_segging.js

@@ -1,40 +0,0 @@
-const migrate_name = 'oidc_config_setting';
-const settingModel = require('../models/setting');
-const logger       = require('../logger').migrate;
-
-/**
-	* Migrate
-	*
-	* @see http://knexjs.org/#Schema
-	*
-	* @param   {Promise} Promise
-	* @returns {Promise}
-	*/
-exports.up = function () {
-	logger.info('[' + migrate_name + '] Migrating Up...');
-
-	return settingModel
-		.query()
-		.insert({
-			id:          'oidc-config',
-			name:        'Open ID Connect',
-			description: 'Sign in to Nginx Proxy Manager with an external Identity Provider',
-			value:       'metadata',
-			meta:        {},
-		});
-};
-
-/**
-	* Undo Migrate
-	*
-	* @param   {Promise} Promise
-	* @returns {Promise}
-	*/
-exports.down = function () {
-	logger.info('[' + migrate_name + '] Migrating Down...');
-
-	return settingModel
-		.query()
-		.delete()
-		.where('setting_id', 'oidc-config');
-};

backend/setup.js

@@ -131,7 +131,7 @@ const setupDefaultUser = () => {
  * @returns {Promise}
  */
 const setupDefaultSettings = () => {
-	return settingModel
+	return Promise.all([settingModel
 		.query()
 		.select(settingModel.raw('COUNT(`id`) as `count`'))
 		.where({id: 'default-site'})
@@ -148,8 +148,20 @@ const setupDefaultSettings = () => {
 						meta:        {},
 					})
 					.then(() => {
-						logger.info('Default settings added');
+						logger.info('Added default-site setting');
 					});
+			}
+			if (debug_mode) {
+				logger.debug('Default setting setup not required');
+			}
+		}),
+		settingModel
+			.query()
+			.select(settingModel.raw('COUNT(`id`) as `count`'))
+			.where({id: 'oidc-config'})
+			.first()
+			.then((row) => {
+				if (!row.count) {
 					settingModel
 						.query()
 						.insert({
@@ -160,13 +172,13 @@ const setupDefaultSettings = () => {
 							meta:        {},
 						})
 						.then(() => {
-						logger.info('Default settings added');
+							logger.info('Added oidc-config setting');
 						});
 				}
 				if (debug_mode) {
 					logger.debug('Default setting setup not required');
 				}
-		});
+			})]);
 };
 
 /**