mirror of
				https://github.com/NginxProxyManager/nginx-proxy-manager.git
				synced 2025-10-31 15:53:33 +00:00 
			
		
		
		
	Return generic auth error to prevent user enumeration attacks
On invalid user/password error the error message "Invalid email or password" is returned. Thereby, no information about the existence of the user is given.
This commit is contained in:
		| @@ -5,6 +5,8 @@ const authModel  = require('../models/auth'); | ||||
| const helpers    = require('../lib/helpers'); | ||||
| const TokenModel = require('../models/token'); | ||||
|  | ||||
| const ERROR_MESSAGE_INVALID_AUTH = 'Invalid email or password'; | ||||
|  | ||||
| module.exports = { | ||||
|  | ||||
| 	/** | ||||
| @@ -69,15 +71,15 @@ module.exports = { | ||||
| 													}; | ||||
| 												}); | ||||
| 										} else { | ||||
| 											throw new error.AuthError('Invalid password'); | ||||
| 											throw new error.AuthError(ERROR_MESSAGE_INVALID_AUTH); | ||||
| 										} | ||||
| 									}); | ||||
| 							} else { | ||||
| 								throw new error.AuthError('No password auth for user'); | ||||
| 								throw new error.AuthError(ERROR_MESSAGE_INVALID_AUTH); | ||||
| 							} | ||||
| 						}); | ||||
| 				} else { | ||||
| 					throw new error.AuthError('No relevant user found'); | ||||
| 					throw new error.AuthError(ERROR_MESSAGE_INVALID_AUTH); | ||||
| 				} | ||||
| 			}); | ||||
| 	}, | ||||
|   | ||||
		Reference in New Issue
	
	Block a user